fix: Resolving MutualTLSChannelError 'OpenSSL' module error on by adding pyopenssl dependency in pyproject.toml#4322
Conversation
…ing pyopenssl dependency in pyproject.toml - Add 'pyopenssl' to project dependencies to fix MutualTLSChannelError encountered during mTLS channel configuration.
Summary of ChangesHello @agrawalradhika-cell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a MutualTLSChannelError by adding pyopenssl as a dependency. My review includes a suggestion to add a version upper bound and a descriptive comment for this new dependency to improve maintainability and align with the existing format of other dependencies in pyproject.toml.
|
Hi @agrawalradhika-cell , closing this here as i see an approved CL. |
fix: Resolving MutualTLSChannelError 'OpenSSL' module error on by adding pyopenssl dependency in pyproject.toml
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
The ADK (Agent Development Kit) fails with a MutualTLSChannelError because the google-auth library cannot find the OpenSSL module during mTLS channel configuration.
Solution:
Dependency Hardening for (pyopenssl)
Testing Plan
Tested on colab with a test-branch fix and see that the module error doesn't persist after the fix. See colab for more details
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Checklist
Additional context
Add any other context or screenshots about the feature request here.